[WIP] avm2: Store resolved function param types #11954
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's an ugly WIP-POC-prototype thing.
ResolvedParamConfig
feels silly, maybe new gc-arena's Cell-like apis would help clean it up.(I also wish the signature stuff was unified/shared between native and bytecode method types.)
Now that
has_class_in_chain
PR is merged, this passes all tests c:This removes all runtime parameter type name lookups from function calls. In my microbenchmarks, for
function f(a: int, b: int, c: int, d: int, e: int)
, this speeds up calls by ~30%.The remaining overhead is
UpdateContext
cloning