core: Make underlines the same color as their text #12088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a visual test for it please? We need more coverage for text stuff 😅 |
What's the protocol if there are significant other text differences that I don't want to fix?
|
|
Totally fine - the image is a snapshot to make sure we don't unintentionally regress. Whenever that stuff does get fixed up, the test will be reviewed by whomever and they'll see that either it's better, or it's worse and they come out with a bonus test case for their changes :D |
MrCheeze
force-pushed
the
underline-color-fix
branch
6 times, most recently
from
cf84b32 to
259f1a8
Compare
Dinnerbone
approved these changes
Jul 15, 2023
Dinnerbone
force-pushed
the
underline-color-fix
branch
from
259f1a8 to
ad4ef0e
Compare
Note that the underline's vertical position is wrong, meaning that the expected.png will have to be updated whenever this is fixed.
Dinnerbone
force-pushed
the
underline-color-fix
branch
from
ad4ef0e to
9ac0e29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue 1 from #10481 (underlines appear to be missing, because they are black on a black background, when they should be in the text color).