Implement flash.filters.BevelFilter avm1 built-in #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CUB3D
changed the title
Herschel
reviewed
Sep 23, 2020
Comment on lines
32
to
41
| let highlight_color = args | ||
| .get(2) | ||
| .unwrap_or(&0xFFFFFF.into()) | ||
| .coerce_to_i32(activation)?; | ||
|
|
||
| let highlight_color_clamped = if highlight_color.is_negative() { | ||
| 0x1000000 - (highlight_color.abs() % 0x1000000) | ||
| } else { | ||
| highlight_color % (0x1000000) | ||
| }; |
There was a problem hiding this comment.
I think this can just be coerce_to_u32 and then color & 0xffffff
Herschel
reviewed
Sep 23, 2020
|
|
||
| let angle = args | ||
| .get(1) | ||
| .unwrap_or(&44.9999999772279.into()) |
There was a problem hiding this comment.
I wonder if the almost-45 default means the angle is actually stored as radians (in an f32?), and the getters/setters convert to/from degrees, or similar? Not sure, something to keep in mind and maybe test more thoroughly someday.
Herschel
reviewed
Sep 23, 2020
Comment on lines
54
to
58
| let shadow_color_clamped = if shadow_color.is_negative() { | ||
| 0x1000000 - (shadow_color.abs() % 0x1000000) | ||
| } else { | ||
| shadow_color % (0x1000000) | ||
| }; |
Herschel
reviewed
Sep 23, 2020
Comment on lines
103
to
114
| bevel_filter.set_distance(activation.context.gc_context, distance); | ||
| bevel_filter.set_angle(activation.context.gc_context, clamped_angle); | ||
| bevel_filter.set_highlight_color(activation.context.gc_context, highlight_color_clamped); | ||
| bevel_filter.set_highlight_alpha(activation.context.gc_context, highlight_alpha); | ||
| bevel_filter.set_shadow_color(activation.context.gc_context, shadow_color_clamped); | ||
| bevel_filter.set_shadow_alpha(activation.context.gc_context, shadow_alpha); | ||
| bevel_filter.set_blur_x(activation.context.gc_context, blur_x); | ||
| bevel_filter.set_blur_y(activation.context.gc_context, blur_y); | ||
| bevel_filter.set_strength(activation.context.gc_context, strength); | ||
| bevel_filter.set_quality(activation.context.gc_context, quality); | ||
| bevel_filter.set_type(activation.context.gc_context, type_); | ||
| bevel_filter.set_knockout(activation.context.gc_context, knockout); |
There was a problem hiding this comment.
If these setters are going to clamp the values, do we have to do it above too? Seems like we're doing it twice
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements flash.filters.BevelFilter (#292)
This also fixes the issue with
clone()for filter objects mentioned in my previous pr (#1041)