avm2: Use invisible mask descendants for mouse picking and rendering #12150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dinnerbone
approved these changes
Jul 19, 2023
Aaron1011
force-pushed
the
hit-invisible-mask
branch
from
95c7d1e to
e28c02c
Compare
torokati44
reviewed
Jul 19, 2023
Aaron1011
force-pushed
the
hit-invisible-mask
branch
from
e28c02c to
f9baebe
Compare
The 'DisplayObject.visible' flag seems to be ignored for mask objects (and their descendants) - mouse picking still takes them into account, and they get rendered as part of the mask. This commit changes display object rendering and AVM2 mouse picking to ignore DisplayObject.visibility when dealing with mask objects/ descendants.
Dinnerbone
force-pushed
the
hit-invisible-mask
branch
from
f9baebe to
10507db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'DisplayObject.visible' flag seems to be ignored for mask objects (and their descendants) - mouse picking still takes them into account, and they get rendered as part of the mask.
This commit changes display object rendering and AVM2 mouse picking to ignore DisplayObject.visibility when dealing with mask objects/ descendants.
Fixes #12107