Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Silence warnings on latest Rust nightly regarding wstr's impl of PartialOrd #12169

Closed
wants to merge 1 commit into from

Conversation

kmeisthax
Copy link
Member

No description provided.

@kmeisthax
Copy link
Member Author

I was advised on Discord not to merge this as Clippy's proposed fix is wrong. See rust-lang/rust-clippy#11188

@kmeisthax kmeisthax closed this Jul 20, 2023
@Centri3
Copy link

Centri3 commented Jul 20, 2023

Hey, you should probably add #[automatically_derived] in a separate PR so it doesn't lint :)

@danielhjacobs
Copy link
Contributor

@Centri3 That seems to be giving the error "you are implementing Ord explicitly but have derived PartialOrd" in #12298.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants