avm2: Implement AMF Vector serialization/deserialization #12240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dinnerbone
approved these changes
Jul 23, 2023
adrian17
reviewed
Jul 24, 2023
core/src/avm2/amf.rs
Outdated
| @@ -8,6 +9,8 @@ use enumset::EnumSet; | |||
| use flash_lso::types::{AMFVersion, Element, Lso}; | |||
| use flash_lso::types::{Attribute, ClassDefinition, Value as AmfValue}; | |||
|
|
|||
| use super::object::VectorObject; | |||
There was a problem hiding this comment.
can't we merge it into use crate::avm2::object on line 2?
adrian17
approved these changes
Jul 24, 2023
Some of the tests are currently disabled because (separate from this PR) we can't actually run `toString()` on a Vector.<Object>, due to our broken vector handling.
This was referenced Jul 25, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the tests are currently disabled because (separate from this PR) we can't actually run
toString()on a Vector., due to our broken vector handling.