core+tests: Socket testing and improvements #12262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleepycatcoding
force-pushed
the
socket_testing
branch
from
8b0bbec to
713e3ee
Compare
mocket |
Darnit I saw that text and immediately scrolled down to comment mocket too. +1 for mocket. |
|
Sadly we're not the first ones to make this portmanteau: |
Dinnerbone
added
the
waiting-on-review
Dinnerbone
approved these changes
Jul 26, 2023
There was a problem hiding this comment.
Awesome work once again!
I think I'd quite like some utility stuff in the socket format, for texts/floats/common data types, so we don't need to write out everything in bytes. But that's a nit and can come at any time later.
This all looks great to me, thank you!
This is used to help to create/test socket.json files against real Flash Player to verify behavior.
Previously it used run which tries to run until completion, but we can't do that if we are testing socket behavior.
This improves socket latency. Sometimes the ping is better in Ruffle than in Flash Player!
Also use anyhow to remove some unwraps.
For some reason my IDE keeps adding random stuff :(
Also reduce float precision.
Dinnerbone
force-pushed
the
socket_testing
branch
from
b96896d to
021ee6a
Compare
Lord-McSweeney
removed
the
waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support in SWF regression testing framework to mock a socket. Also some improvements to the general socket framework.
List of things left to do:
socket_mockutility.Socketnow that the backend exists