wgpu: Fixes for blur filter quality #12276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torokati44
added
render-wgpu
|
If its not used in actually rendering, surely you'd see the bounds of a large blur be cut off by the max texture size which is now smaller than the kernel size? |
|
Sorry, I don't understand what you mean... The sizes of some of the rainbow squares on |
torokati44
force-pushed
the
blur-quality
branch
4 times, most recently
from
d6a0890 to
161e993
Compare
torokati44
force-pushed
the
blur-quality
branch
2 times, most recently
from
a867dd8 to
cfddeb6
Compare
Dinnerbone
approved these changes
Jul 26, 2023
…nd filters/applyFilter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on, and currently includes, the changes from #12225.Turns out, the
PASS_SCALESthing is not needed for actual filtering at all.