avm2+tests: Allow setting prototype to undefined #12282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleepycatcoding
force-pushed
the
set_prototype_undefined
branch
from
7d22829 to
28b1049
Compare
adrian17
reviewed
Jul 24, 2023
|
BTW minor note for the future: if an avm2 feature PR includes a test for it, then I'd just mark it as |
sleepycatcoding
force-pushed
the
set_prototype_undefined
branch
from
e8f206e to
cc6c9a4
Compare
adrian17
approved these changes
Jul 24, 2023
This is used internally by Adobe Flex in many places. Also add test.
adrian17
force-pushed
the
set_prototype_undefined
branch
from
cc6c9a4 to
5dc66a2
Compare
danielhjacobs
pushed a commit
to danielhjacobs/ruffle
that referenced
this pull request
Aug 28, 2023
* avm2+tests: Allow setting prototype to undefined This is used internally by Adobe Flex in many places. Also add test. * avm2: Set prototype when constructing a Function with null prototype * tests: Expand prototype_set_null test * chore: fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is used internally by Adobe Flex in many places.
Progresses #12078, #12054, #11789