avm2: Fix handling of default domain memory #12308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian17
approved these changes
Jul 25, 2023
Aaron1011
force-pushed
the
default-domain-memory
branch
from
d147ec6 to
6928d9e
Compare
Whenever `ApplicationDomain.domainMemory` is set to `null` (which is the default value), domain memory opcodes read from use hidden ByteArray in the domain. This hidden bytearray object is re-used if `ApplicationDomain.domainMemory` is ever set back to `null`.
Aaron1011
force-pushed
the
default-domain-memory
branch
from
6928d9e to
584e84d
Compare
This was referenced Jul 26, 2023
This was referenced Jul 28, 2023
danielhjacobs
pushed a commit
to danielhjacobs/ruffle
that referenced
this pull request
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever
ApplicationDomain.domainMemoryis set tonull(which is the default value), domain memory opcodes read from use hidden ByteArray in the domain. This hidden bytearray object is re-used ifApplicationDomain.domainMemoryis ever set back tonull.