Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

desktop: Change 'socket mode' text to 'TCP Connections' #12316

Merged
merged 1 commit into from
Jul 26, 2023
Merged

desktop: Change 'socket mode' text to 'TCP Connections' #12316

merged 1 commit into from
Jul 26, 2023

Conversation

Dinnerbone
Copy link
Contributor

No description provided.

@torokati44
Copy link
Member

Are the string IDs good as is?

@Dinnerbone
Copy link
Contributor Author

Unless we deliberately want to invalidate every current translation. Do we?

@torokati44
Copy link
Member

Since the original language text (English) changes, they are pretty much already invalid, just not technically, no?

@sleepycatcoding
Copy link
Member

Shouldn't we change the command line flag too, no?

@Dinnerbone Dinnerbone merged commit 55906c2 into ruffle-rs:master Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleepycatcoding sleepycatcoding sleepycatcoding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dinnerbone @torokati44 @sleepycatcoding