tests: Add known_failure as a test option, and migrate many tests to it #12324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dinnerbone
added
the
waiting-on-review
|
Hmm, this name implies to me that a given test is a "negative test" and that the expected result (ie. when Ruffle is working correctly) is that it fails. Sure, the message it gives explains that this is not the case, but in the test itself it's not there. How about "known_fails" (or something similar)? I like the basic idea though! |
|
I just took the name Adrian said and rolled with it, didn't give much thought. Happy to change it! |
Excellent IMHO! |
…ass on my machine
|
Renamed! |
Dinnerbone
changed the title
sleepycatcoding
approved these changes
Jul 26, 2023
adrian17
approved these changes
Jul 26, 2023
Lord-McSweeney
removed
the
waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to use
known_failure = trueinstead ofignore = truefor tests that we know don't work now, but may work one day.When a test is marked
known_failure, it'll be tested and the comparison logic is inverted. If it suddenly passes, it'll throw an error and the developer will be prompted to unflag it as the test now passes and should be checked going forwards for regressions.