extension: Fix some minor issues #12917
Conversation
n0samu
commented
Aug 23, 2023
n0samu
commented
- Fix improper spacing around the "Open in a new tab" button due to wrongly structured HTML:
- Don't show a CORS error on the internal player page, which is not subject to CORS restrictions.
n0samu
force-pushed
the
extension-fixes
branch
from
cb54061 to
ade6efd
Compare
| } else if ( | ||
| window.location.origin === this.swfUrl!.origin || | ||
| // The extension's internal player page is not restricted by CORS | ||
| window.location.protocol.includes("extension") |
There was a problem hiding this comment.
Does this part work for Edge?
There was a problem hiding this comment.
Yes, Edge's extension protocol is called extension:. I've never seen a Chromium-based browser that used an extension protocol not including the word "extension" in its name.
EDIT: Oh that's funny, Edge actually uses chrome-extension: internally but displays it in the address bar as extension:.
| const div = document.createElement("div"); | ||
| div.id = "message_overlay"; | ||
| const innerDiv = document.createElement("div"); | ||
| innerDiv.className = "message"; | ||
| innerDiv.innerHTML = textAsParagraphs("message-cant-embed"); |
There was a problem hiding this comment.
This can be innerText or textContent now, right? Or is message-cant-embed an HTML element? We should be moving away from innerHTML.
There was a problem hiding this comment.
Oh no, I see textAsParagraphs returns an HTML string. It should return an HTMLDivElement though ideally, so you can just appendChild the result.
There was a problem hiding this comment.
IIUC this should be fixed in #12937, right? Let's merge this as-is for now.
The player page is not restricted by CORS
torokati44
force-pushed
the
extension-fixes
branch
from
ade6efd to
2e73876
Compare
