avm2: Improve XMLList set_local_property #13255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evilpie
reviewed
Sep 20, 2023
sleepycatcoding
force-pushed
the
xml_list_set_property
branch
3 times, most recently
from
c7aa098 to
683ab18
Compare
|
I think I will also implement the other path in this PR as it actually does not seem that complicated as I thought it was. |
sleepycatcoding
force-pushed
the
xml_list_set_property
branch
3 times, most recently
from
995ab1e to
f4f784a
Compare
adrian17
approved these changes
Oct 2, 2023
| /// for resolving the value of empty XMLLists. | ||
| #[derive(Clone, Collect, Copy, Debug)] | ||
| #[collect(no_drop)] | ||
| pub enum XmlOrXmlListObject<'gc> { |
There was a problem hiding this comment.
personally I'd probably keep using an Object, but I guess this is slightly safer.
sleepycatcoding
force-pushed
the
xml_list_set_property
branch
2 times, most recently
from
b2a47a1 to
f88e4a9
Compare
adrian17
pushed a commit
to sleepycatcoding/ruffle
that referenced
this pull request
Oct 5, 2023
Fixes test `e11_6_1` when combined ruffle-rs#13255.
adrian17
pushed a commit
that referenced
this pull request
Oct 5, 2023
Fixes test `e11_6_1` when combined #13255.
sleepycatcoding
force-pushed
the
xml_list_set_property
branch
3 times, most recently
from
ee6f248 to
3ef8785
Compare
Lord-McSweeney
approved these changes
Oct 8, 2023
sleepycatcoding
force-pushed
the
xml_list_set_property
branch
from
3ef8785 to
df8f475
Compare
Dinnerbone
approved these changes
Oct 9, 2023
sleepycatcoding
force-pushed
the
xml_list_set_property
branch
2 times, most recently
from
9d8c9a6 to
9ae5dcc
Compare
This is not mentioned in the E4X specification, but this is what avmplus seems to be doing.
Fixes a borrow panic and logic error.
sleepycatcoding
force-pushed
the
xml_list_set_property
branch
from
9ae5dcc to
cbc816c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves
RustError("Modifying an XMLList object is not yet implemented: need to resolve")errors.Fixes #2444
Fixes #10540
Fixes #12173
Fixes #12406
TODO: