Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web: As appropriate use embed height mentioned in Mozilla bug 810082 c65 #13256

Merged
merged 2 commits into from
Oct 3, 2023
Merged

web: As appropriate use embed height mentioned in Mozilla bug 810082 c65 #13256

merged 2 commits into from
Oct 3, 2023

Conversation

danielhjacobs
Copy link
Contributor

@danielhjacobs danielhjacobs mentioned this pull request Sep 20, 2023
Closed
@danielhjacobs danielhjacobs force-pushed the better-style-updates branch 4 times, most recently from 10e56b3 to 28bfc51 Compare September 24, 2023 15:43
Dinnerbone
Dinnerbone approved these changes Sep 30, 2023
View reviewed changes
Copy link
Contributor

@Dinnerbone Dinnerbone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@danielhjacobs danielhjacobs force-pushed the better-style-updates branch 2 times, most recently from ec0f486 to f6abf4c Compare October 2, 2023 18:23
@Dinnerbone Dinnerbone enabled auto-merge (rebase) October 3, 2023 18:04
@Dinnerbone Dinnerbone merged commit 48c7c52 into ruffle-rs:master Oct 3, 2023
13 checks passed
@Benman2785
Copy link

Benman2785 commented Oct 4, 2023 •
edited
Loading

this is bugged! (or my html that worked before is wrong)

i now have bugs in firefox and edge and chrome

i am now FORCED to specify height in px and cant use 100%

simply test with "tlS1" (fixed height px) & "tlS2" (100% width & height)
just check: https://hoffmeister.li/flash-games/
image

@Benman2785
Copy link

https://hoffmeister.li/flash-games/index_test.html shows old behaviour

@danielhjacobs
Copy link
Contributor Author

I think that's the min-height that I didn't take into account.

@Benman2785
Copy link

can you fix your code to make it work again?

@danielhjacobs
Copy link
Contributor Author

Has nothing to do with min-height: this logic just doesn't apply to iframes.

@Benman2785
Copy link

https://hoffmeister.li/flash-games/The_last_Stand_2_2023-10-04.html
this logic is flawed even if not in iFrame...

@danielhjacobs
Copy link
Contributor Author

danielhjacobs commented Oct 4, 2023 •
edited
Loading

You're right, I found the real issue, and it's something I had actually noticed before. This logic only applies if the Flash embed/object is on a page or in an iframe with <!DOCTYPE html>. The sizing would be the same in Flash if you added that to the game HTML page.

danielhjacobs added a commit to danielhjacobs/ruffle that referenced this pull request Oct 4, 2023
@danielhjacobs
web: Fix ruffle-rs#13256 (comment)
e6df4c4
@Benman2785
Copy link

Benman2785 commented Oct 4, 2023 •
edited
Loading

thats not the problem:
https://hoffmeister.li/flash-games/The_last_Stand_2_2023-10-04.html
error persists // yet have to try your fork

@danielhjacobs
Copy link
Contributor Author

That's not what I meant. I meant this bug exists in Ruffle because this matches Flash's behavior when using <!DOCTYPE html>.

@adrian17 adrian17 mentioned this pull request Oct 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dinnerbone Dinnerbone Dinnerbone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielhjacobs @Benman2785 @Dinnerbone