core: Allow Regular/Bold/Italic device fonts to be registered separately #14083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dinnerbone
approved these changes
Nov 24, 2023
Dinnerbone
force-pushed
the
bold-device-font
branch
from
df52d18 to
064dcc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing #13604 , I noticed that if I provide fontSources swf(s) that contain the same font in multiple styles (Regular, Bold, Italic, Bold Italic), only one of the provided fonts will actually be registered, and the others discarded - meaning that bolded text will appear unbolded or vice versa.
This PR solves that issue by registering device fonts in a FontMap (like embedded and global fonts are), instead of registering them by name alone and ignoring the style.
If that wasn't clear, here's what rendering text looks like when all four styles of a device font have been provided, before and after this change:
