-
-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: avm2,audio: Implement SampleDataEvent
#14203
base: master
Are you sure you want to change the base?
Conversation
27be9ab
to
8e7465b
Compare
Most NSFW video games depend on this commit, here still no any SFX, but now they panics after the end of the first loop (need to wait for the issue reproduction)
upd: here one my favorite chiptune site, music is playing http://zxtunes.com/author.php?id=446&sort=playing :D |
8e7465b
to
ee06332
Compare
ee06332
to
30b855a
Compare
30b855a
to
de195ac
Compare
de195ac
to
59c88bb
Compare
TBD:
|
|
||
ba.set_position(0); | ||
for _ in 0..ba.len() / 4 { | ||
ns.push_back(ba.read_float().expect("float can be read")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't failing to read a float result in the read loop terminating early?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that is to be tested :|
aa09e74
to
0610048
Compare
0610048
to
1812e00
Compare
1812e00
to
0ef97dd
Compare
0ef97dd
to
0e4032c
Compare
Fixes: #14156
Also fixes z0r.de loops: 5885, 7024 (issue #7879), 7312
Probably fixes (to be tested): #9171, #13655
It's quite rough (full of
unwrap()
s for example, and overall unfinished) but it "just started working".Mostly pushing to show that it's in progress - any ideas on how to improve the architecture are welcome.
An unexpected (to me at least) problem is that sound synthesis in AS3 needs to do quite a lot of math really fast, so on my machine, even in release mode, the content linked above could barely keep up with real time sound generation, or not at all. Profiling and optimization is yet to be done (probably related: #7920).