-
-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP/POC AVM2 verifier #14563
Closed
Closed
WIP/POC AVM2 verifier #14563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anch Includes scope stack and local register verification.
…y; implement VerifyError 1013
…when inside a freestanding function; implement VerifyError 1113 Implementing Error 1113 prevents a panic when using `newactivation` within a method that does not `NEED_ACTIVATION`
…ments and `this` into
Lord-McSweeney
force-pushed
the
avm2-verifier
branch
from
December 31, 2023 10:42
9059a7e
to
cb8d57a
Compare
Nice. I imagine shrinking the Opcode size would improve this even more. |
…Method`'s `try_verify` to `needs_verify`
This was referenced Jan 2, 2024
Closing in favor of #14631. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based off @adrian17's original work on his peephole optimizer branch (see #7920 and a newer branch)
This results in noticeable performance increases on #10560 (6-7% decrease in startup time and even more, clearly noticeable improvements in gameplay) and in #12303.
This supersedes the main part of #14496, the opcode reading optimizations.
TODO:
iftrue
,iffalse
, etc)- example: verify.zipparsed_code
on the method itself rather than inAbcMethodBody
AbcMethodBody
seems unnecessary, and is mostly leftover from Adrian's original workThis allows for further optimizations that actually modify the bytecode, such as #7920.