Code

AVM2 verifier#14631

Code

Merged

Lord-McSweeney merged 25 commits intoruffle-rs:masterruffle-rs/ruffle:masterfrom Lord-McSweeney:avm2-verifier-no-mergeLord-McSweeney/ruffle:avm2-verifier-no-mergeCopy head branch name to clipboardJan 30, 2024

+1,765-441

Commits

Commits on Jan 30, 2024

• avm2: Implement verifier based off Adrian's initial work

  

  Lord-McSweeney

  authored and

  Lord-McSweeney

  committed
  a6f1590

• avm2: Add an Op enum to AVM2; pre-pool double/uint/ints for pushX opcodes

  

  Lord-McSweeney

  authored and

  Lord-McSweeney

  committed
  ad445f7

• avm2: Record all possible jump targets, remove Convert-B/D/I/U opcodes since those are equivalent to the corresponding CoerceX opcodes

  

  Lord-McSweeney

  authored and

  Lord-McSweeney

  committed
  ec863ff

• avm2: Implement simple Op::CoerceX optimizations

  

  Lord-McSweeney

  authored and

  Lord-McSweeney

  committed
  2b77c14

• avm2: Add default xml namespace handling opcodes since several SWFs mention them but don't actually use them

  

  Lord-McSweeney

  authored and

  Lord-McSweeney

  committed
  e718d4d

• avm2: Optimize a GetProperty after a GetLocal0 to GetSlot or CallMethod

  

  Lord-McSweeney

  authored and

  Lord-McSweeney

  committed
  4bb317a

• avm2: Remove Label op since it is only relevant to the verifier, inline CoerceA and Nop

  

  Lord-McSweeney

  authored and

  Lord-McSweeney

  committed
  3f6d277

• avm2: Add optimizations for Coerce and AsType after PushNull, fix optimize panicking when out-of-bounds local registers are mentioned

  

  Lord-McSweeney

  authored and

  Lord-McSweeney

  committed
  43bb058

• avm2: Add CoerceU op optimizations

  

  Lord-McSweeney

  authored and

  Lord-McSweeney

  committed
  c858272

• avm2: Make verify_code_starting_from use a worklist instead of running recursively

  Show description for 8b63980
  

  Lord-McSweeney

  authored and

  Lord-McSweeney

  committed
  8b63980

• avm2: Optimize Coerce out when it comes right after another Coerce pointing to the same cpool entry

  

  Lord-McSweeney

  authored and

  Lord-McSweeney

  committed
  63ba3c2

• swf: Remove PushConstant AVM2 opcode

  

  Lord-McSweeney

  authored and

  Lord-McSweeney

  committed
  bed8f1f

• avm2: Resolve reviews

  

  Lord-McSweeney

  authored and

  Lord-McSweeney

  committed
  18ad76c

• avm2: Add more ops that are guaranteed to not throw errors to verify::ops_can_throw_error

  Show description for 6cd3ab3
  

  Lord-McSweeney

  authored and

  Lord-McSweeney

  committed
  6cd3ab3

• avm2: Optimize unnecessary Coerce when it comes after PushString, NewArray, and NewFunction

  

  Lord-McSweeney

  authored and

  Lord-McSweeney

  committed
  3ac3581

• avm2: Fix crash when Coerce/AsType used a lazy multiname

  

  Lord-McSweeney

  authored and

  Lord-McSweeney

  committed
  1c304e8

• avm2: Add longer comment to logic to determine register types

  

  Lord-McSweeney

  authored and

  Lord-McSweeney

  committed
  f843b1e

• avm2: Fix some potentially-failing unwraps and broken code in the verifier

  

  Lord-McSweeney

  authored and

  Lord-McSweeney

  committed
  2fbe596

• avm2: One more lazy multiname fix

  

  Lord-McSweeney

  authored and

  Lord-McSweeney

  committed
  a04060d

• tests: Add a test for AVM2 verification

  

  Lord-McSweeney

  authored and

  Lord-McSweeney

  committed
  c0ad794

• avm2: Fix a minor bug where CoerceD was removed after Inc/DecLocal

  

  Lord-McSweeney

  authored and

  Lord-McSweeney

  committed
  b72cde1

• avm2: Properly verify constant pool lookups for Op::Coerce and Op::AsType

  

  Lord-McSweeney

  authored and

  Lord-McSweeney

  committed
  8e8b299

• avm2: Op::Coerce should not accept a 0-index Multiname

  

  Lord-McSweeney

  authored and

  Lord-McSweeney

  committed
  d1a1906

• avm2: Write a make_error_1032 function and use it

  

  Lord-McSweeney

  authored and

  Lord-McSweeney

  committed
  c862121

• avm2: Resolve review comments and fix verifier brokenness

  

  Lord-McSweeney

  authored and

  Lord-McSweeney

  committed
  190669d