avm1,avm2: Implement TextField.restrict #14634
Conversation
|
Updated the branch and included the support for pasting (turned out it's not a lot of code). Please let me know if there's anything to improve. |
|
This does a fair bit of stuff, including extending our testing capabilities, adding tests (for both of which, thank you very much!), adding a new type, implementing both AVM1 and AVM2 properties - all in a single commit. Maybe it would be better to split it into a couple logically separate commits that build on each other...? |
kjarosh
force-pushed
the
restrict
branch
3 times, most recently
from
69aab69 to
e17fda9
Compare
|
Thanks for the review! I've split the god commit into multiple ones. I hope it's now structured in a better way, if you have any suggestions related to the structure of commits please do not hesitate. |
| // Caret according to the documentation indicates | ||
| // that we are now disallowing characters. | ||
| // In reality it just switches allowing/disallowing. | ||
| now_allowing = !now_allowing; |
There was a problem hiding this comment.
lol, nice misdocumentation, and great that you discovered it
(just babbling, no action necessary)
There was a problem hiding this comment.
TBH it looks like an implementation detail leak. Someone at Macromedia did not think more than one caret may be included in restrict 😃
There was a problem hiding this comment.
Yep. And we have seen a lot of these kinds of leaks.
There was a problem hiding this comment.
So, thanks, Hyrum's Law...
https://www.hyrumslaw.com/
| for interval in intervals { | ||
| if self.interval_contains(character, interval) { | ||
| return true; | ||
| } | ||
| } | ||
| false |
There was a problem hiding this comment.
I guess this could have been a call to any, but this isn't any less readable, and no need to delay further just for this.
EditTextRestrict models the `restrict` property, which is used to specify which characters the user is allowed to type.
Currently in tests (input.json) it is possible to trigger Ctrl-V using:
{ "type": "TextControl", "code": "Paste" },
But there is no way of populating the clipboard.
This patch adds AutomatedEvent::SetClipboardText, so the clipboard
may be populated before pasting:
{ "type": "SetClipboardText", "text": "<value>" },
{ "type": "TextControl", "code": "Paste" },
I implemented
TextField.restrictfor both AVM1 and AVM2 (with minor differences). I also added extensive testing to make sure how the restrict actually works, because the documentation is very vague (and wrong in one case).Currently restrict in Ruffle works only when inputting characters one by one, not when pasting a string (flashplayer does not differentiate between inputting and pasting characters in this case).
I'm working on a second PR which will add support for restrict when pasting (it requires more complex testing).Support for restrict when pasting is included.I guess it's a step towards completing #280.
If I see correctly it's also related to #12613.