Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avm2: Optimizer improvements #15105

Merged
merged 13 commits into from
Feb 26, 2024
Merged

avm2: Optimizer improvements #15105

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
57b3bff
avm2: More advanced optimizer
Feb 3, 2024
aff47f1
avm2: Handle more ops in abstract optimizer
Feb 3, 2024
45c793a
avm2: Support type inference for chained `GetProperty`s
Feb 3, 2024
951f501
chore: cleanup
Feb 3, 2024
781de6f
chore: appease clippy
Feb 3, 2024
54d483b
avm2: Add more ops to optimizer and let it use resolved argument types
Feb 4, 2024
51774a5
avm2: Also optimize `CallProperty` to `CallMethod` when possible
Feb 4, 2024
13b592e
avm2: Add `push_raw` for faster stack pushes
Feb 7, 2024
ad85fc2
avm2: Extract optimizer logic into a different file
Feb 7, 2024
916d0c2
avm2: Don't use a `Class`'s first `ClassObject` for its VTable if mor…
Feb 19, 2024
9f25a3a
avm2: Add a `popn` function to `Stack` and use it
Feb 19, 2024
d2971e8
avm2: Handle lazy multinames in optimizer
Feb 24, 2024
dce4238
avm2: Resolve reviews (no functional changes)
Feb 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions core/src/avm2.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ mod multiname;
mod namespace;
pub mod object;
mod op;
mod optimize;
mod parameters;
pub mod property;
mod property_map;
Expand Down Expand Up @@ -622,6 +623,16 @@ impl<'gc> Avm2<'gc> {
self.stack.push(value);
}

/// Push a value onto the operand stack.
/// This is like `push`, but does not handle `PrimitiveObject`
/// and does not check for stack overflows.
#[inline(always)]
fn push_raw(&mut self, value: impl Into<Value<'gc>>) {
let value = value.into();
avm_debug!(self, "Stack push {}: {value:?}", self.stack.len());
self.stack.push(value);
}

/// Retrieve the top-most value on the operand stack.
#[allow(clippy::let_and_return)]
#[inline(always)]
Expand Down
Loading