Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Compile Rust tests in release mode #15241

Closed
wants to merge 1 commit into from

Conversation

torokati44
Copy link
Member

Let's see whether this is faster now...

Afterwards, I think it would still be favorable to create a custom Rust profile for CI, where optimizations are enabled, but debug checks are not disabled.

Also note that our cargo cache is primed with debug artifacts, so it's not trivial to accurately measure this.

@torokati44 torokati44 marked this pull request as draft February 16, 2024 15:22
@torokati44
Copy link
Member Author

torokati44 commented Feb 25, 2024

Current test times with empty cache:
image

With perfectly primed cache:
image

Cache sizes:
770, 770, 770, 550, 720 MB

With this PR, and empty cache:

image

With this PR, and perfectly primed cache:

image

Cache sizes:
580, 570, 650, 560, 490 MB

@torokati44
Copy link
Member Author

torokati44 commented Feb 25, 2024

After adding a new build profile, as follows:

[profile.ci]
inherits = "release"
opt-level = 2
debug-assertions = true
overflow-checks = true
incremental = true

For reference, we already had this:

[profile.release]
panic = "abort"

I get this on an empty cache:

image

And on a primed cache:

image

Cache sizes:
580, 650, 570, 570, 490 MB

While not 7, but still more than 6 minutes faster than the 22 minutes it is right now.

@torokati44 torokati44 closed this Feb 25, 2024
@torokati44 torokati44 deleted the ci-nextest-release-mode branch February 25, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant