Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define distinct key types for different kinds of slotmaps #15401

Merged
merged 5 commits into from
Mar 3, 2024

Conversation

torokati44
Copy link
Member

Followup for #15383.

I didn't dare touch web/lib.rs, because "scary JS interop", but that is the only SlotMap left with DefaultKey, so there probably won't be any confusion with that.

An ACK for the audio behavior change in streams.rs from @kmeisthax would be appreciated. I think this has been a bug so far, resulting from the exact same type of confusion that this PR is aiming to prevent in the future.

@torokati44 torokati44 changed the title Define Define distinct key types for different kinds of slotmaps Mar 3, 2024
@torokati44
Copy link
Member Author

Added some more cleanup commits.
Hopefully this won't actually revert the bug that #1395 fixed with the workaround.

@adrian17 adrian17 force-pushed the slotmap-handle-types branch from 30c35aa to 6a1231e Compare March 3, 2024 20:04
@adrian17 adrian17 enabled auto-merge (rebase) March 3, 2024 20:04
@adrian17 adrian17 merged commit 85dd258 into ruffle-rs:master Mar 3, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants