ci: Properly exclude large stuff from the reproducible FF extension source zip #15543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fixup for #15518 and #15066, because the reproducible source zip in https://github.com/ruffle-rs/ruffle/releases/tag/nightly-2024-03-12 is still 800M+.
Turns out,
zipdoesn't exclude an entire folder unless the exclusion pattern ends with/*- looks like it does a sort of string matching, rather than the usual recursive FS globbing?Also,
-xtakes a list of patterns, no need to specify it multiple times.I've also added the
web/docker/docker_buildsfolder to the exclusion list, just to be safe.