avm2: Fix Object.prototype.toString applied to Vector

core/src/avm2/object.rs

@@ -977,11 +977,7 @@ pub trait TObject<'gc>: 'gc + Collect + Debug + Into<Object<'gc>> + Clone + Copy
             .map(|c| c.read().name().local_name())
             .unwrap_or_else(|| "Object".into());
 
-        Ok(AvmString::new_utf8(
-            activation.context.gc_context,
-            format!("[object {class_name}]"),
-        )
-        .into())
+        Ok(AvmString::new_utf8(activation.gc(), format!("[object {class_name}]")).into())
     }
 
     /// Implement the result of calling `Object.prototype.toLocaleString` on this

core/src/avm2/object/vector_object.rs

@@ -3,6 +3,7 @@
 use crate::avm2::activation::Activation;
 use crate::avm2::object::script_object::ScriptObjectData;
 use crate::avm2::object::{ClassObject, Object, ObjectPtr, TObject};
+use crate::avm2::string::AvmString;
 use crate::avm2::value::Value;
 use crate::avm2::vector::VectorStorage;
 use crate::avm2::Error;
@@ -250,8 +251,19 @@ impl<'gc> TObject<'gc> for VectorObject<'gc> {
         }
     }
 
-    fn to_string(&self, _activation: &mut Activation<'_, 'gc>) -> Result<Value<'gc>, Error<'gc>> {
-        Ok(Value::Object(Object::from(*self)))
+    // Implements the special `Object.prototype.toString` behavior for Vector.
+    fn to_string(&self, activation: &mut Activation<'_, 'gc>) -> Result<Value<'gc>, Error<'gc>> {
+        let inner_name = if let Some(class_object) = self.0.read().vector.value_type() {
+            class_object
+                .inner_class_definition()
+                .read()
+                .name()
+                .to_qualified_name(activation.gc())
+        } else {
+            AvmString::new_utf8(activation.gc(), "*")
+        };
+
+        Ok(AvmString::new_utf8(activation.gc(), format!("[object Vector.<{inner_name}>]")).into())
     }
 
     fn value_of(&self, _mc: &Mutation<'gc>) -> Result<Value<'gc>, Error<'gc>> {

tests/tests/swfs/avm2/vector_object_toString/Test.as

@@ -0,0 +1,21 @@
+package {
+  import flash.display.Sprite;
+  public class Test extends Sprite {
+    public function Test() {
+      trace("// Object.prototype.toString.call(new Vector.<*>())");
+      trace(Object.prototype.toString.call(new Vector.<*>()));
+
+      trace("// Object.prototype.toString.call(new Vector.<Object>())");
+      trace(Object.prototype.toString.call(new Vector.<Object>()));
+
+      trace("// Object.prototype.toString.call(new Vector.<String>())");
+      trace(Object.prototype.toString.call(new Vector.<String>()));
+
+      trace("// Object.prototype.toString.call(new Vector.<XML>())");
+      trace(Object.prototype.toString.call(new Vector.<XML>()));
+
+      trace("// Object.prototype.toString.call(new Vector.<Sprite>())");
+      trace(Object.prototype.toString.call(new Vector.<Sprite>()));
+    }
+  }
+}

tests/tests/swfs/avm2/vector_object_toString/output.txt

@@ -0,0 +1,10 @@
+// Object.prototype.toString.call(new Vector.<*>())
+[object Vector.<*>]
+// Object.prototype.toString.call(new Vector.<Object>())
+[object Vector.<Object>]
+// Object.prototype.toString.call(new Vector.<String>())
+[object Vector.<String>]
+// Object.prototype.toString.call(new Vector.<XML>())
+[object Vector.<XML>]
+// Object.prototype.toString.call(new Vector.<Sprite>())
+[object Vector.<flash.display::Sprite>]

tests/tests/swfs/avm2/vector_object_toString/test.toml

@@ -0,0 +1 @@
+num_frames = 1