core,avm1: Add support for controlling focus highlight with _focusrect
#15838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the Object properties are available only in SWF6+.
The property `_focusrect` allows specifying whether an object should be highlighted by keyboard focus. For SWF <=5 that was possible globally, and since SWF 6 the global option only has been the default, which may be overridden using a local `_focusrect` property.
This test verifies the behavior of _focusrect for SWF 7.
This test verifies the behavior of _focusrect for SWF 6.
This test verifies the behavior of _focusrect for SWF 5.
The field `focus_rect` is available for each interactive object, and its value is used to control highlight rendering. The notable exception is the TextField, which despite having a focus, is incapable of rendering a highlight. That is why the `focus_rect_supported` field has been added to control this behavior.
This test verifies the behavior of _focusrect for SWF6.
This test verifies the behavior of _focusrect for SWF5.
Although full AVM2 support is not there yet, stageFocusRect is not ignored anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5443.
This patch adds support for
_focusrectin AVM1 along with tests:_focusrectproperty for SWF 5,6,7_focusrectbehavior regarding focus highlight rendering for SWF 5,6The property
_focusrectallows specifying whether an object should be highlighted by keyboard focus. For SWF <=5 that was possible globally, and since SWF 6 the global option only has been the default, which may be overridden using a local_focusrectproperty. Regarding the behavior of the property itself, tests were added for SWF 5,6,7 to cover all differences, which include treating the property value as bool/number or using the property in different contexts.The field
focus_rectis available for each interactive object, and its value is used to control highlight rendering. The notable exception is the TextField, which despite having a focus, is incapable of rendering a highlight. That is why thefocus_rect_supportedfield has been added to control this behavior.