web: Rewrite AMO submission script to use their v5 API directly #15844
Conversation
torokati44
force-pushed
the
drop-sign-addon
branch
4 times, most recently
from
b9a4120 to
002952c
Compare
|
Changed terminology from "sign" to "submit", because we're always getting this result anyway:
Apparently, signing only occurs after manual verification. Therefore, no need/way to download a new, signed XPI right away either. Plus, Mozilla calls their old, and to be deprecated, v4 API the "signing" API, and the new v5 API the "submission" API. |
torokati44
force-pushed
the
drop-sign-addon
branch
2 times, most recently
from
780e8f4 to
afca07d
Compare
torokati44
force-pushed
the
drop-sign-addon
branch
from
afca07d to
27435b1
Compare
|
Thankfully Axios automatically throws an error if the status code of any response is <200 or >299, and the AMO API is "well-behaved" in this manner, so no need to do much checking of that ourselves. |
torokati44
added
the
waiting-on-review
| @@ -9,7 +9,7 @@ | |||
| "build": "tsc -p jsconfig.json && npm run build:generic && npm run build:firefox", | |||
| "build:generic": "webpack --env generic && node tools/inject_plugin_polyfill.js && node tools/zip.js dist/ruffle_extension.zip", | |||
| "build:firefox": "webpack --env firefox && node tools/inject_plugin_polyfill.js && node tools/zip.js dist/firefox_unsigned.xpi && npm run sign-firefox", | |||
| "sign-firefox": "node tools/sign_xpi.js dist/firefox_unsigned.xpi dist/firefox.xpi ../../../reproducible-source.zip" | |||
| "sign-firefox": "node tools/submit_xpi.js dist/firefox_unsigned.xpi ../../../reproducible-source.zip" | |||
There was a problem hiding this comment.
Should I also rename this script too, to submit_xpi or submit_to_amo or something like that? 🤔
Dropping the deprecated sign-addon package.
Dinnerbone
force-pushed
the
drop-sign-addon
branch
from
27435b1 to
8f82c36
Compare
Lord-McSweeney
removed
the
waiting-on-review
Using
axiosas an HTTP client instead of the deprecatedsign-addonpackage.See: https://github.com/mozilla/sign-addon/releases/tag/6.4.0
This will resolve https://github.com/ruffle-rs/ruffle/security/dependabot/44 and https://github.com/ruffle-rs/ruffle/security/dependabot/52, by dropping the outdated
requestpackage.This will also unblock #15731.