frontend-utils: Add TableExt trait #15870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleepycatcoding
force-pushed
the
table_ext_trait
branch
from
ae24243 to
3630f77
Compare
torokati44
force-pushed
the
table_ext_trait
branch
from
3630f77 to
f5649a5
Compare
Dinnerbone
approved these changes
Apr 4, 2024
This moves the logic previously found in BookmarkWriter's `with_underlying_table` into a common trait to be reused by other writers.
torokati44
force-pushed
the
table_ext_trait
branch
from
f5649a5 to
d8082eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the logic previously found in BookmarkWriter's
with_underlying_tableinto a common trait to be reused by other writers.