avm2: Implement tabEnabled, tabIndex, and tabChildren
#16050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
force-pushed
the
tab-ordering-avm2
branch
2 times, most recently
from
04e3600 to
891fa8e
Compare
kjarosh
changed the title
tabEnabled and tabIndex for InteractiveObjecttabEnabled, tabIndex, and tabChildren
kjarosh
force-pushed
the
tab-ordering-avm2
branch
from
891fa8e to
c2d7ae6
Compare
kjarosh
force-pushed
the
tab-ordering-avm2
branch
2 times, most recently
from
ca71483 to
15ab1fc
Compare
Dinnerbone
approved these changes
Apr 29, 2024
Add a case of a dynamic text field with tab enabled.
Add a case of a non-editable text field.
The i32/u32 discrepancy is only a data presentation issue, as the value is treated as i32 in every case.
This test verifies the behavior of i32/u32 discrepancy in tabIndex in AVM1.
The focus handler should also be called for AVM2 buttons when the focus is being changed.
The field tab_enabled in AVM1 is effectively read-only as tabEnabled is not a built-in property of objects. That is not the case in AVM2, where tab_enabled is native. This patch covers both of these cases by introducing methods: * tab_enabled, * set_tab_enabled, * tab_enabled_avm1, * tab_enabled_avm2_default.
This is an AVM2 version of avm1/tab_ordering_tabbable
This is an AVM2 version of avm1/tab_ordering_custom_basic
This is an AVM2 version of avm1/tab_ordering_automatic_basic
This test verifies the behavior of tabChildren.
This is an AVM2 version of avm1/tab_ordering_properties
Dinnerbone
force-pushed
the
tab-ordering-avm2
branch
from
15ab1fc to
2fb00f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5443.
This PR:
InteractiveObject.tabEnabled,InteractiveObject.tabIndex,DisplayObjectContainer.tabChildren,Additionally, some tests were updated with new cases,
tab_indexwas moved toInteractiveObjectand madei32. Thei32/u32discrepancy in AVM1'stabIndexis also covered by a test.cc @adrian17 (regarding the
tab_indexrefactor)