core: Update focus highlight reset logic for SWF9+ #16082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
force-pushed
the
highlight-reset-swf9
branch
2 times, most recently
from
582f251 to
e1a1717
Compare
Dinnerbone
approved these changes
Apr 22, 2024
kjarosh
force-pushed
the
highlight-reset-swf9
branch
from
e1a1717 to
3550c04
Compare
Dinnerbone
force-pushed
the
highlight-reset-swf9
branch
from
3550c04 to
e32bb74
Compare
SWF versions 9 onwards reset the highlight only on left mouse button down, whereas older versions also reset it on other mouse events.
This test verifies the behavior of focus highlight when mouse is moved and mouse buttons are clicked for SWF9.
This test verifies the behavior of focus highlight when mouse is moved and mouse buttons are clicked for SWF8.
torokati44
force-pushed
the
highlight-reset-swf9
branch
from
e32bb74 to
7d7c558
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5443.
SWF versions 9 onwards reset the highlight only on left mouse button down, whereas older versions also reset it on other mouse events.
This behavior is covered by tests.