avm2: Do not highlight Stage on focus #16214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stage is never highlightable, even if there's a focus on it.
Before this patch, focus handlers were called from on_focus_changed, only for selected objects. It seems that they should be called for every object by default.
This test verifies the behavior of focus and focus highlight for the stage object.
sleepycatcoding
approved these changes
May 4, 2024
Lord-McSweeney
approved these changes
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5443. Fixes #16204.
Stage is never highlightable, even if there's a focus on it.
This PR also ensures that focus handlers are called for stage.