core: Allow pressing buttons with keyboard #16281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
force-pushed
the
keyboard-button-press
branch
2 times, most recently
from
efa5e5e to
6bdfc72
Compare
Dinnerbone
approved these changes
May 10, 2024
Some button events (e.g. KeyUp/KeyDown) seem to require a state when the highlight is not visible, but is active (i.e. a focus is selected). That is why this patch introduces a third possible state of the highlight: ActiveHidden.
Since highlight has 3 states now, it's better represented by describing the state instead of having a checkbox. A re-focus button has been added to compensate for the fact that the highlight cannot be automatically enabled anymore.
This condition is identical for buttons and movie clips.
It seems that button event handlers not only require focus to be fired, but also an active highlight.
This patch allows the keyboard to be used (Enter/Space) to press buttons.
This test verifies the behavior of pressing buttons with a keyboard.
This test ensures that button key press events take precedence over pressing focused buttons with keyboard.
Dinnerbone
force-pushed
the
keyboard-button-press
branch
from
6bdfc72 to
54fa583
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5443.
This PR allows the keyboard to be used (Enter/Space) to press buttons.
As always, there are some tests and some related refactors and fixes, described in commit messages.