core: Fix stop() when executing attachMovie in DoInitAction #16384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please check whether this changes anything related to #6144 ? |
For future reference: it does not seem to change anything, for me it worked on the desktop even without this patch. |
kjarosh
force-pushed
the
attach-movie-stop
branch
from
ca87ae4 to
af61146
Compare
danielhjacobs
added
the
waiting-on-review
Dinnerbone
approved these changes
May 28, 2024
This fixes a bug where the code in the first frame of a movie clip could have been executed after the second frame (so that instructions like stop did not work properly). That is because when the first frame was executed in preload (e.g. for a sprite attached using attachMovie), the actions were queued, the second frame was executed in run_frame, and then the actions from the first frame were executed. Ensuring that all actions are executed after preload fixes this issue.
This test verifies that stop() works properly for a movie clip attached with attachMovie in DoInitAction.
Dinnerbone
force-pushed
the
attach-movie-stop
branch
from
af61146 to
57c81a4
Compare
danielhjacobs
removed
the
waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the code in the first frame of a movie clip could have been executed after the second frame (so that instructions like stop did not work properly).
That is because when the first frame was executed in preload (e.g. for a sprite attached using attachMovie), the actions were queued, the second frame was executed in run_frame, and then the actions from the first frame were executed.
Ensuring that all actions are executed after preload fixes this issue.
This issue is related to #5443 as it improves support for
mx.managers.FocusManager(by preventing thetabCaptureobject from disappearing).See the test
attach_movie_stopfor the MWE.