core: Render EditText's selection when filters are present #16422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
force-pushed
the
edittext-select-filters
branch
2 times, most recently
from
763aaf6 to
8f44efb
Compare
danielhjacobs
added
text
Dinnerbone
approved these changes
May 24, 2024
This patch ensures that the selection in EditText is rendered even when filters are present (so that cache as bitmap is enabled). This is done by invalidating the cached bitmap on selection change.
This test verifies that selection is rendered when filters are present.
Dinnerbone
force-pushed
the
edittext-select-filters
branch
from
8f44efb to
20ddfac
Compare
danielhjacobs
removed
the
waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch ensures that the selection in EditText is rendered even when filters are present (so that cache as bitmap is enabled). This is done by invalidating the cached bitmap on selection change.
Fixes #16374.
After this PR the caret is rendered but does not blink (due to the cached bitmap).