Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Store MovieClip avm2_class in MovieClipStatic #16433

Merged

Conversation

Aaron1011
Copy link
Member

This is preparation for allowing a class to be linked to the root movie clip and instantiated.

@danielhjacobs danielhjacobs added the waiting-on-review Waiting on review from a Ruffle team member label May 23, 2024
Copy link
Member

@kmeisthax kmeisthax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty straightforward, and it makes more conceptual sense for the class to live in MovieClipStatic.

core/src/display_object/movie_clip.rs Show resolved Hide resolved
This is preparation for allowing a class to be linked
to the root movie clip and instantiated.
@Aaron1011 Aaron1011 force-pushed the movieclip-avm2class-static-data branch from 7686913 to 0a9b479 Compare May 25, 2024 14:02
@Aaron1011 Aaron1011 enabled auto-merge (rebase) May 25, 2024 14:03
@Aaron1011 Aaron1011 merged commit f8e9780 into ruffle-rs:master May 25, 2024
17 checks passed
@danielhjacobs danielhjacobs removed the waiting-on-review Waiting on review from a Ruffle team member label May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants