avm1: Drop focus on EditText when something else is clicked #16587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
force-pushed
the
avm1-focus-mouse
branch
3 times, most recently
from
944ab6a to
4f899f9
Compare
In AVM1 text fields are somewhat special when handling focus. When a text field is clicked, it gains focus, when something else is clicked, it loses the focus. However, this logic only applies to text fields, other objects (buttons, movie clips) neither gain focus nor lose it upon press.
This test verifies how FP handles focus changes on mouse clicks.
Dinnerbone
force-pushed
the
avm1-focus-mouse
branch
from
4f899f9 to
6a951cd
Compare
danielhjacobs
removed
the
waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In AVM1 text fields are somewhat special when handling focus. When a text field is clicked, it gains focus, when something else is clicked, it loses the focus. However, this logic only applies to text fields, other objects (buttons, movie clips) neither gain focus nor lose it upon press.
This behavior might have appeared inconsistent, as some SWFs lose focus on EditText when something else is clicked, some don't. Turns out that difference results from
mx.managers.FocusManager. It automatically focuses the last focused EditText after click, so that it seemed that the field did not lose the focus. In reality it lost the focus on press, and gained it again on release. Sincemx.managers.FocusManagernow works (#5443), Ruffle will mirror this behavior when this PR is merged.