avm1,avm2: Fix the focus-related behaviors of root movies #16601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dinnerbone
approved these changes
Jun 4, 2024
Root movie clip should be neither focusable, nor tabbable.
This test verifies the behavior of focusing and tabbing into the root movie.
This check is unnecessary as is_focusable is only used in AVM1.
This test verifies the behavior of focus and focusrect on the root movie clip.
Dinnerbone
force-pushed
the
focus-root-movie
branch
from
adb66f1 to
5cb5202
Compare
sleepycatcoding
removed
the
waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AVM1: the root movie should be neither focusable, nor tabbable.
AVM2: the root movie should not be highlightable.
As always, covered by tests.
Fixes #16285, fixes #16588. Related to #5443.