avm2: More work on the class refactor #16655
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work on storing a
Class
instead of aClassObject
as an Object'sinstance_of
, which is necessary for the refactor.Notable changes:
ClassObject
no longer stores its interfacesClassObject
no longer stores its type parameter, and theapplications
map is now aOption<Class>
->ClassObject
map instead of anOption<ClassObject>
->ClassObject
has_class_in_chain
has been moved toClass
Class
now stores a list of all its interfaces (all_interfaces
)ClassKey
andClassHashWrapper
have been removed as they were no longer necessary after avm2: Simplify uses ofGcCell<'gc, Class<'gc>>
#16128VectorStorage
now stores the value type as aClass
instead of aClassObject
ClassObject
has been moved into its own function,ClassObject::parametrize