Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core,desktop: Update wgpu to v0.20.1, bump egui #16704

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

torokati44
Copy link
Member

egui actually reverted to wgpu 0.19 for a while (emilk/egui#4559), but now that gfx-rs/wgpu#5681 fixed the reasons for the downgrade, they have updated again: emilk/egui#4560

The little egui API change was: emilk/egui#4556

@torokati44
Copy link
Member Author

torokati44 commented Jun 13, 2024

Trying to fix CI by updating WARP, as per: gfx-rs/wgpu#5591 (comment)
EDIT: No longer, as it's probably a more general runner image problem instead.

@torokati44 torokati44 force-pushed the wgpu-0.20.1 branch 3 times, most recently from 680430e to 807ec02 Compare June 13, 2024 16:12
@torokati44 torokati44 marked this pull request as draft June 13, 2024 16:32
@torokati44 torokati44 force-pushed the wgpu-0.20.1 branch 4 times, most recently from 81c0507 to 024f129 Compare June 17, 2024 08:39
@torokati44 torokati44 marked this pull request as ready for review June 17, 2024 08:39
@torokati44 torokati44 force-pushed the wgpu-0.20.1 branch 2 times, most recently from e8f37e0 to 354a4ab Compare June 18, 2024 18:01
@torokati44
Copy link
Member Author

In the meantime, emilk/egui#4641 got merged too, so bumping egui to include that as well, so #16639 can fully come to fruition!

@torokati44
Copy link
Member Author

Hmmm, it seems that this now drops accesskit. Is that a problem? Shall we add it back?
https://docs.rs/crate/egui/latest/features#accesskit

@Dinnerbone
Copy link
Contributor

It looks like it was always an optional dependency that we didn't enable... not sure where it came from before, to get enabled?

@Dinnerbone
Copy link
Contributor

Locally on master, accesskit is not being used

@torokati44
Copy link
Member Author

Well then, it should probably be fine.

@torokati44 torokati44 merged commit 35f5227 into ruffle-rs:master Jun 18, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants