wgpu: Do not use 'packed' as variable name in WGSL shaders #16805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be something that naga deals with, we should raise an issue there too. |
|
This fixes #12844 for me |
kjarosh
force-pushed
the
wgsl-packed-keyword
branch
from
22dca8a to
c8cce84
Compare
|
Raised an issue about that: gfx-rs/wgpu#5853 |
adrian17
approved these changes
Jun 22, 2024
torokati44
force-pushed
the
wgsl-packed-keyword
branch
from
c8cce84 to
75f2bf1
Compare
Turns out that 'packed' is a keyword in some GLSL shaders, and naga currently preserves it, producing a syntax error. As a workaround, this patch renames the variable to something else.
kjarosh
force-pushed
the
wgsl-packed-keyword
branch
from
75f2bf1 to
a801bd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12844, fixes #16642.
Turns out that 'packed' is a keyword in some GLSL shaders, and naga currently preserves it, producing a syntax error.
As a workaround, this patch renames the variable to something else.