avm2: Implement TextField.getLineIndexOfChar()
#16906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
force-pushed
the
textfield-line-index-of-char
branch
2 times, most recently
from
0315521 to
3b2cd0d
Compare
evilpie
reviewed
Jun 27, 2024
| return Ok(Value::Number(-1f64)); | ||
| } | ||
|
|
||
| return if let Some(line) = this.line_index_of_char(index as usize) { |
There was a problem hiding this comment.
How come clippy didn't catch this then? :O
There was a problem hiding this comment.
Removed some more unnecessary returns
evilpie
approved these changes
Jun 27, 2024
kjarosh
force-pushed
the
textfield-line-index-of-char
branch
2 times, most recently
from
c7a2009 to
603c84a
Compare
kjarosh
added
text
Verifies the behavior of TextField.getLineIndexOfChar().
kjarosh
force-pushed
the
textfield-line-index-of-char
branch
from
603c84a to
5d56b91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
TextField.getLineIndexOfChar().Related to #14668.