Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sponsor link underline #16954

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Fix sponsor link underline #16954

merged 3 commits into from
Jul 2, 2024

Conversation

dnicolson
Copy link
Contributor

This fixes link underlines when there is whitespace within anchor tags on WebKit/Blink.

Before and after:

torokati44
torokati44 approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@torokati44 torokati44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also works in Firefox, thank you!

@torokati44
Copy link
Member

(Note before merging - maybe tag the commit message appropriately, by "squashing" the PR.)

@torokati44 torokati44 enabled auto-merge (rebase) July 2, 2024 21:41
@torokati44 torokati44 disabled auto-merge July 2, 2024 21:41
@torokati44
Copy link
Member

(Will squash and merge once I can rebase from the web UI again. :) )

@torokati44 torokati44 enabled auto-merge (squash) July 2, 2024 21:57
@torokati44 torokati44 merged commit 803a8c4 into ruffle-rs:master Jul 2, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrian17 adrian17 adrian17 approved these changes

@torokati44 torokati44 torokati44 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Merged PRs since last progress update
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dnicolson @torokati44 @adrian17