wgpu: Don't use textures for shader cache keys #17014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian17
force-pushed
the
dont-recompile-shaders-on-texture-change
branch
3 times, most recently
from
879f5fd to
3375a92
Compare
Aaron1011
approved these changes
Jul 6, 2024
adrian17
force-pushed
the
dont-recompile-shaders-on-texture-change
branch
3 times, most recently
from
9b3d2e3 to
08cf01f
Compare
Dinnerbone
approved these changes
Jul 6, 2024
adrian17
force-pushed
the
dont-recompile-shaders-on-texture-change
branch
from
08cf01f to
5e35ba1
Compare
n0samu
added
A-rendering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces number of shader recompiles in
ShaderPairAgal::compile:This results in major (2x, 4x) fps improvements on web (tested on firefox) on a lot of Stage3D content.
On FPA4, there are still some runtime webgl shader recompiles left; that's still to be researched :(