Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web: Update ws manually until new webdriverio major update #17028

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

web: Update ws manually until new webdriverio major update #17028

wants to merge 1 commit into from

Conversation

Dinnerbone
Copy link
Contributor

Removes our security alert (not that it actually affected us)

(webdriverio/webdriverio#13056)

torokati44
torokati44 reviewed Jul 7, 2024
View reviewed changes
web/package-lock.json
Comment on lines -11026 to +11100
"version": "8.13.0",
"resolved": "https://registry.npmjs.org/ws/-/ws-8.13.0.tgz",
"integrity": "sha512-x9vcZYTrFPC7aSIbj7sRCYo7L/Xb8Iy+pW0ng0wt2vCJv7M9HOMy0UoN3rr+IFC7hb7vXoqS+P9ktyLLLhO+LA==",
"version": "7.5.10",
Copy link
Member

@torokati44 torokati44 Jul 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is... a downgrade here...? Is that a problem?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a problem

@torokati44
Copy link
Member

torokati44 commented Jul 7, 2024 •
edited
Loading

Also are we not just gonna forget to undo this in a couple months when it's gonna be due?
I'm not opposed to it BTW, just asking.

@Dinnerbone
Copy link
Contributor Author

I think it's fine, even if we forget 😅

torokati44
torokati44 reviewed Jul 7, 2024
View reviewed changes
web/package.json
Comment on lines +52 to +59
"overrides": {
"ws": "^7.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A TODO comment to "remove this when ..." would be appreciated! 🥺
Otherwise, I'm fine with this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it would be!

But alas, json

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, frick, heck, right.
looks up how much json5everywhere.org would cost...

@torokati44
Copy link
Member

I think it's fine, even if we forget 😅

Could you please elaborate? 😶
Won't this prevent updating to a 8.x.x version of ws?
Or it will be updated in the proper place, and this override will break other stuff no longer compatible with 7.x.x, and we'll be reminded that way? 🤔

@Dinnerbone
Copy link
Contributor Author

Could you please elaborate? 😶

Well, mostly it just doesn't matter what version of ws we're using, this is such an inconsequential part of things as far as I can see. If we miss a new version... oh well? :D

@danielhjacobs
Copy link
Contributor

A new webdriverio major version was released. The upgrade is in #17533, though we also need a new release of @wdio/browserstack-service with webdriverio/webdriverio#13374 to fix the failures there.

@danielhjacobs
Copy link
Contributor

New PR: #17539

@danielhjacobs danielhjacobs added A-deps Area: Dependencies T-chore Type: Chore (like updating a dependency, it's gotta be done) labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torokati44 torokati44 torokati44 left review comments

Assignees
No one assigned
Labels
A-deps Area: Dependencies T-chore Type: Chore (like updating a dependency, it's gotta be done)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dinnerbone @torokati44 @danielhjacobs