text: Fix caret positioning in empty text fields #17319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
changed the title
Dinnerbone
approved these changes
Jul 31, 2024
Dinnerbone
force-pushed
the
edittext-caret-empty
branch
from
390600a to
9617cb3
Compare
This test used device fonts, this patch embeds Noto Sans and uses it instead.
That condition related to drawing a cursor when there are no boxes is outdated, as currently it's guaranteed that there's at least one box. FormatSpans.normalize() ensures that there's at least one span, and LayoutContext.fixup_line() ensures that each line has at least one box.
Before this patch, max font size (which claimed to be the highest font size observed within the current line) was calculated for each span, regardless of newlines.
This patch fixes how empty text boxes are laid out. The empty boxes are now added during line fixup, and not after, which ensures they are subjected to alignment and other adjustments.
This test verifies how the caret in a text field is rendered when the text field is empty.
kjarosh
force-pushed
the
edittext-caret-empty
branch
from
9617cb3 to
32561b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14716, fixes #3802, progresses #10852.
Summary of changes:
avm1/edittext_scrollis fixed — it used device fonts, now Noto Sans has been embedded,avm1/edittext_scrollof course),