Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avm2: report more correct Capabilities.os #17517

Closed
wants to merge 1 commit into from

Conversation

Mesteery
Copy link
Contributor

Not very accurate but probably better than nothing

@n0samu
Copy link
Member

n0samu commented Aug 14, 2024

See also: #10469
I think it was never merged because we weren't able to agree on how much information we want to expose, how accurate it should be, etc :(

@Mesteery
Copy link
Contributor Author

Mesteery commented Aug 14, 2024

Yes I can understand. But some AIR applications rely on os for example, to find an OS-specific path, or use FileStream instead of URLLoader for macOS platforms (in case of Dofus), so for theses applications a correct os value is important and can possibly break the game if it's wrong

@evilpie
Copy link
Collaborator

evilpie commented Aug 15, 2024

We could do this for AIR only. I also think this changes thw OS for everything running on the web/extension to Linux, which we most likely don't want to do. Windows is a much much larger market.

@Mesteery
Copy link
Contributor Author

What if we put Windows instead of Linux in the else?

@Mesteery
Copy link
Contributor Author

Closing in favor of #17590

@Mesteery Mesteery closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants