Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

desktop: Internationalize metainfo and desktop file #18091

Merged
merged 7 commits into from
Oct 1, 2024
Merged

desktop: Internationalize metainfo and desktop file #18091

merged 7 commits into from
Oct 1, 2024

Conversation

kjarosh
Copy link
Member

@kjarosh kjarosh commented Sep 27, 2024

The main idea behind translation of metainfo and desktop file:

  1. Define the .in versions of these files without any translations.
  2. Generate a PO template (.pot) files from .in.
  3. Upload these files to Crowdin, but do not commit them.
  4. Download translated .po files from Crowdin.
  5. Apply these translations to the original input files (.in), but do not commit them.
  6. Save output to the expected paths of metainfo and desktop file (without .in).

@kjarosh kjarosh added A-desktop Area: Desktop Application linux T-feature Type: New Feature (that Flash doesn't have) waiting-on-review Waiting on review from a Ruffle team member labels Sep 27, 2024
@kjarosh kjarosh requested a review from Dinnerbone September 29, 2024 09:21
Dinnerbone
Dinnerbone approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@Dinnerbone Dinnerbone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'm mostly trusting that you know this stuff :D

kjarosh added 7 commits October 1, 2024 19:30
@kjarosh
desktop: Rename metainfo to rs.ruffle.Ruffle.metainfo.xml.in
352e7d2 
In order to make this file translatable, we have to store its source
(as an .in file), and the original path will store its final version.
@kjarosh
desktop: Rename desktop file to rs.ruffle.Ruffle.desktop.in
198391c 
In order to make this file translatable, we have to store its source
(as an .in file), and the original path will store its final version.
@kjarosh
desktop: Internationalize metainfo and desktop file
553c2da 
The added Makefile may be used to easily generate PO templates for translation
and apply PO translations to the final metainfo and desktop file.
@kjarosh
i18n: Add metainfo and desktop file to Crowdin config
400e0ef
@kjarosh
ci: Upload metainfo and desktop file POTs for translation
7aad724
@kjarosh
ci: Download translated POs for metainfo and desktop file
b939b25
@kjarosh
desktop: Generate initial translated metainfo and desktop file
97c6e1e 
Those files do not include translations, they will be overridden
by Crowdin when syncing translations.
@kjarosh kjarosh merged commit 33a4f86 into ruffle-rs:master Oct 1, 2024
17 checks passed
@kjarosh kjarosh deleted the metainfo-i18n branch October 1, 2024 19:18
@danielhjacobs danielhjacobs removed the waiting-on-review Waiting on review from a Ruffle team member label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torokati44 torokati44 torokati44 left review comments

@Dinnerbone Dinnerbone Dinnerbone approved these changes

Assignees
No one assigned
Labels
A-desktop Area: Desktop Application linux T-feature Type: New Feature (that Flash doesn't have)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kjarosh @torokati44 @Dinnerbone @danielhjacobs