Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Credit translators properly #18212

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kjarosh
Copy link
Member

@kjarosh kjarosh commented Oct 8, 2024

This adds a TRANSLATORS file to acknowledge and credit contributors who provided translations for Ruffle.

Crowdin unfortunately does not allow crediting translators when synchronizing translations (crowdin/github-action#35).

@kjarosh kjarosh added A-other Area: Not covered by other area labels T-chore Type: Chore (like updating a dependency, it's gotta be done) labels Oct 8, 2024
This adds a TRANSLATORS file to acknowledge and credit
contributors who provided translations for Ruffle.
@torokati44
Copy link
Member

Hah, I've only ever actually contributed Hungarian translations - the rest were small typo fixes, restored earlier submissions by others, etc... 😅

@torokati44
Copy link
Member

And maybe @Dinnerbone is in a similar situation? Not sure...

@kjarosh
Copy link
Member Author

kjarosh commented Oct 8, 2024

A contribution is a contribution! Even fixing typos and selecting better translations are considered contributions (IMO at least). The same way our code is changed: most of the time we edit and improve existing code, but each (even the smallest) contribution is credited in the commit history.

@torokati44
Copy link
Member

and selecting better translations are considered contributions

In at least one occasion, it wasn't even a selection - just mass-copying the old strings after the source texts changed ever so slightly. But fine, I don't mind being listed many times... 🤷‍♂️

Copy link
Member

@torokati44 torokati44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@torokati44
Copy link
Member

BTW, somewhat related:
https://github.com/ruffle-rs/ruffle/blob/master/LICENSE.md#third-party-libraries and https://github.com/ruffle-rs/ruffle/blob/master/web/LICENSE.md#third-party-libraries are redundant (or unnecessarily overlapping?), and are getting more and more outdated every week.

https://crates.io/crates/cargo-attribution and https://www.npmjs.com/package/@electrovir/oss-attribution-generator (or similar) might come in handy in updating these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-other Area: Not covered by other area labels T-chore Type: Chore (like updating a dependency, it's gotta be done)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants