-
-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Credit translators properly #18212
base: master
Are you sure you want to change the base?
Conversation
This adds a TRANSLATORS file to acknowledge and credit contributors who provided translations for Ruffle.
Hah, I've only ever actually contributed Hungarian translations - the rest were small typo fixes, restored earlier submissions by others, etc... 😅 |
And maybe @Dinnerbone is in a similar situation? Not sure... |
A contribution is a contribution! Even fixing typos and selecting better translations are considered contributions (IMO at least). The same way our code is changed: most of the time we edit and improve existing code, but each (even the smallest) contribution is credited in the commit history. |
In at least one occasion, it wasn't even a selection - just mass-copying the old strings after the source texts changed ever so slightly. But fine, I don't mind being listed many times... 🤷♂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
BTW, somewhat related: https://crates.io/crates/cargo-attribution and https://www.npmjs.com/package/@electrovir/oss-attribution-generator (or similar) might come in handy in updating these. |
This adds a TRANSLATORS file to acknowledge and credit contributors who provided translations for Ruffle.
Crowdin unfortunately does not allow crediting translators when synchronizing translations (crowdin/github-action#35).