Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extension: Disable Ruffle on Duo Security #18299

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

danielhjacobs
Copy link
Contributor

My organization uses https://outlook.office.com secured by Duo Security, and they use Duo Security's check for Flash installation to ensure you don't log in with Flash installed. Unfortunately or fortunately depending on how you look at it, Ruffle is detected as Flash. We can't avoid that without fooling fewer plugin detection scripts used to enable Flash content, so we instead have to disable Ruffle on this site.

@danielhjacobs danielhjacobs added A-web Area: Web & Extensions extension Related to the Ruffle WebExtension T-fix Type: Bug fix (in something that's supposed to work already) labels Oct 17, 2024
@danielhjacobs
Copy link
Contributor Author

More info about this is available here: https://duo.com/docs/policy#plugins

Copy link
Contributor

@Dinnerbone Dinnerbone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably start marking all these exceptions with relevant issues/PRs explaining them 😅 the list is getting long

@danielhjacobs
Copy link
Contributor Author

I can link to this PR or directly to https://duo.com/docs/policy#plugins. Which do you think is better for this?

@Dinnerbone
Copy link
Contributor

I think the PR

@Dinnerbone
Copy link
Contributor

We should probably also find a way to merge the lists...
But this doesn't have to be done for this PR at all!

@danielhjacobs
Copy link
Contributor Author

We should probably also find a way to merge the lists...
But this doesn't have to be done for this PR at all!

I'll save that part for the future, since combining ts and json5 sounds difficult, but I added the links to issues/PRs

@Dinnerbone Dinnerbone enabled auto-merge (rebase) October 17, 2024 14:19
@Dinnerbone Dinnerbone merged commit 0b66946 into ruffle-rs:master Oct 17, 2024
15 checks passed
@danielhjacobs danielhjacobs deleted the disable-ruffle-duosecurity branch October 17, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-web Area: Web & Extensions extension Related to the Ruffle WebExtension T-fix Type: Bug fix (in something that's supposed to work already)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants