Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Reformat AS3 code using asformat #18439

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

evilpie
Copy link
Collaborator

@evilpie evilpie commented Nov 1, 2024

This is the result of formatting our current AS3 code using the Apache Royale Formatter. To be honest, I'm not a big fan of the result, simply because I don't like it when braces are added to a new line. It also doesn't fit in with our current style.

If we do decide to land this, we could add a CI lint check that ensures all AS3 in pull requests is correctly formatted.

public function splitTextElement(elementIndex:int, splitIndex:int):TextElement
{
var element = getElementAt(elementIndex);
if (!(elementinstanceof TextElement))
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it apparently produces wrong code ...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issues has been fixed by
apache/royale-compiler@975a04b

@danielhjacobs danielhjacobs added A-avm2 Area: AVM2 (ActionScript 3) T-chore Type: Chore (like updating a dependency, it's gotta be done) labels Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-avm2 Area: AVM2 (ActionScript 3) T-chore Type: Chore (like updating a dependency, it's gotta be done)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants